| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: recovery_target_action=pause with confusing hint |
| Date: | 2020-03-09 17:27:20 |
| Message-ID: | CA+TgmobnbpPMPRfPEAchOYUr2OyGBhOoSM+Wnm2US=XNfrOjDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 9, 2020 at 12:03 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> I started the discussion about the topic very related to this.
> I'm thinking to apply the change that Sergei proposes after applying
> the patch I attached in this thread.
> https://postgr.es/m/00c194b2-dbbb-2e8a-5b39-13f14048ef0a@oss.nttdata.com
I think it would be good to change the primary message, not just the hint. e.g.
LOG: pausing at end of recovery
HINT: Execute pg_wal_replay_resume() to promote.
vs.
LOG: recovery has paused
HINT: Execute pg_wal_replay_resume() to continue.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-03-09 17:29:47 | Re: DROP and ddl_command_end. |
| Previous Message | Robert Haas | 2020-03-09 17:16:47 | Re: backup manifests |