Re: Assert "target_wal_endrec == divergerec" in pg_rewind

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Stepan Neretin <slpmcf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Assert "target_wal_endrec == divergerec" in pg_rewind
Date: 2026-11-20 07:56:54
Message-ID: av_9RifledMdAV8W@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 19, 2026 at 08:47:51PM +0100, Daniel Gustafsson wrote:
> From reading over the thread in which Heikki concluded it was a bogus Assert,
> I'd say it's still worth committing. I do think the TAP test should be in line
> with the other pg_rewind tests though.

Dropping the assertion sounds good.

My first impression about the test was that it did not seem like it
was worth the cycles, but I'm convinced by its coverage on closer
read: cases for direct ancestors based on backups are interesting to
have.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-11-20 08:00:49 Re: Checkpoints stuck after a failed bulk write inside a savepoint
Previous Message Antonin Houska 2026-11-20 07:54:58 Re: Table AM callback for logical decoding support (REPACK CONCURRENTLY)