Re: Assert "target_wal_endrec == divergerec" in pg_rewind

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Stepan Neretin <slpmcf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Assert "target_wal_endrec == divergerec" in pg_rewind
Date: 2026-11-20 08:15:53
Message-ID: 7748B903-F875-4544-9A55-BB1F06DF4C81@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 20 Nov 2026, at 08:56, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Nov 19, 2026 at 08:47:51PM +0100, Daniel Gustafsson wrote:
>> From reading over the thread in which Heikki concluded it was a bogus Assert,
>> I'd say it's still worth committing. I do think the TAP test should be in line
>> with the other pg_rewind tests though.
>
> Dropping the assertion sounds good.

Thanks for confirming, I'll go ahead with this.

> My first impression about the test was that it did not seem like it
> was worth the cycles, but I'm convinced by its coverage on closer
> read: cases for direct ancestors based on backups are interesting to
> have.

That was my initial reaction too, but I also came to the conclusion that this
test does in fact cover a case which doesn't have good coverage today.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-11-20 08:17:35 Re: pgstat: Flush some statistics within running transactions, take 2
Previous Message David Geier 2026-11-20 08:14:30 Re: Use local buffer for packed numerics