| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Stepan Neretin <slpmcf(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Assert "target_wal_endrec == divergerec" in pg_rewind |
| Date: | 2026-11-19 19:47:51 |
| Message-ID: | 804FA996-B7B3-4A93-A824-81FE5A1D73C5@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 16 Nov 2026, at 20:13, Stepan Neretin <slpmcf(at)gmail(dot)com> wrote:
> Attached is a small rebase on current master, with the TAP coverage
> folded into "005_same_timeline.pl". No behaviour change outside
> assertion builds.
use warnings FATAL => 'all';
+use PostgreSQL::Test::Cluster;
use PostgreSQL::Test::Utils;
The proposed TAP test breaks the current model where tests use the
infrastructure in the RewindTest module. Is there a reason why this test
should be different?
> Does this still seem worth committing?
From reading over the thread in which Heikki concluded it was a bogus Assert,
I'd say it's still worth committing. I do think the TAP test should be in line
with the other pg_rewind tests though.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-11-19 20:01:34 | Re: Hash aggregate collisions cause excessive spilling |
| Previous Message | Heikki Linnakangas | 2026-11-19 19:32:42 | Re: Let OpenSSL auto-select DH parameters by default |