Re: BUG #19629: pg_restore_relation_stats reports XX000 instead of proper SQLSTATE for input validation errors

On Wed, Aug 19, 2026 at 09:42:18PM +0530, Ayush Tiwari wrote:
> On Wed, 19 Aug 2026 at 20:52, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> I think this should be backpatched to v18, where
>> pg_restore_relation_stats() and pg_restore_attribute_stats() were
>> introduced.
>>
>> Thought?

Adding an errcode() is a life improvement thing. So, while I agree
that the proposed patch is an improvement, I don't see a strong need
for a backpatch. Feel free to override this argument as you feel, of
course.

Just a note: I've tried to be careful with assigning errcodes for all
the new error paths of extended_stats_funcs.c added in v19 that can be
reached by SQL. If there are holes in there, please let me know.

> Found some more places where the issue exists and added
> there. Maybe you can incorporate those too in your patch?

I'd suggest to keep things isolated in their own fashion, as they
address different areas with slightly different user-changes changes
(okay, not much).
--
Michael