Re: BUG #19629: pg_restore_relation_stats reports XX000 instead of proper SQLSTATE for input validation errors

On Fri, Aug 21, 2026 at 7:30 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Adding an errcode() is a life improvement thing. So, while I agree
> that the proposed patch is an improvement, I don't see a strong need
> for a backpatch. Feel free to override this argument as you feel, of
> course.

I understand your point, but I'm inclined to backpatch this to v18.

These are input-validation errors that are directly reachable from SQL,
and the SQLSTATE is exposed to applications. Since applications commonly
branch on SQLSTATE, reporting XX000 makes these errors look like internal
errors rather than invalid input. That seems more like a bug than
a cosmetic improvement to me.

Also, these functions were introduced in v18, so the risk of breaking
existing applications that depend on the current XX000 behavior should
be low. For these reasons, I think backpatching to v18 is preferable here.
Thoughts?

But, on the other hand, if we want to avoid breaking existing
applications that depend on the current XX000 behavior, backpatching
to v19 might be a reasonable alternative.

> I'd suggest to keep things isolated in their own fashion, as they
> address different areas with slightly different user-changes changes
> (okay, not much).

+1

Regards,

--
Fujii Masao