Re: question about is_valid parameter in set_attnotnull

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: question about is_valid parameter in set_attnotnull
Date: 2026-08-03 11:54:03
Message-ID: anCBTcrN8csZJQax@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-Jul-30, Chao Li wrote:

> > On Jul 30, 2026, at 02:55, Sami Imseih <samimseih(at)gmail(dot)com> wrote:

> > Right, both the is_valid and thisatt are dead code AFAICT.

> Even from a purely C programming perspective, leaving the unused
> argument and local variable hurts readability. So +1 for removing
> them.

Okay, removed, thanks.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ayush Tiwari 2026-08-03 12:00:51 Re: Add a pg_wal_preallocate() SQL function to eagerly create future WAL segments
Previous Message Rafia Sabih 2026-08-03 11:27:58 Re: Bypassing cursors in postgres_fdw to enable parallel plans