| From: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Yilin Zhang <jiezhilove(at)126(dot)com>, KENAN YILMAZ <kenan(dot)yilmaz(at)localus(dot)com(dot)tr>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bypassing cursors in postgres_fdw to enable parallel plans |
| Date: | 2026-08-03 11:27:58 |
| Message-ID: | CA+FpmFc7EpvxjYwxgSCk437YHJvvmUKSxgOjN+3zEtDpXvsUTg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2 Aug 2026 at 23:38, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Jul 28, 2026 at 5:51 AM Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>
> wrote:
> > Regarding your other point, that's my understanding too that this memset
> is working because it is the only one in struct.
> > Should we also change that to clearing only pendingAreq instead of the
> complete struct memset that it is doing now? Should this be done as a
> separate patch?
>
> Yeah, I think that should probably be changed. Not sure whether it
> needs a separate patch.
>
> Please find the reworked patch set attached.
This version handles the concerns discussed above.
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>
--
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH
| Attachment | Content-Type | Size |
|---|---|---|
| v14-0001-postgres_fdw-Rename-cursor_exists-flag-to-scan_i.patch | application/octet-stream | 4.0 KB |
| v14-0002-postgres_fdw-Add-streaming_fetch-option-for-curs.patch | application/octet-stream | 138.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2026-08-03 11:54:03 | Re: question about is_valid parameter in set_attnotnull |
| Previous Message | Matthias van de Meent | 2026-08-03 11:17:12 | POC: Unlocked path for GetSnapshotDataReuse |