| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | solai v <solai(dot)cdac(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Subject: | Re: Add a pg_wal_preallocate() SQL function to eagerly create future WAL segments |
| Date: | 2026-08-03 12:00:51 |
| Message-ID: | CAJTYsWXLL03tZGJFXo+Yqo3-sNekg9PgPWPRdM9PruiRrz=t5A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, 3 Aug 2026 at 16:38, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> Hi,
>
> Thank you for working on this!
>
> On Mon, 3 Aug 2026 at 08:13, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
> wrote:
> >
> > Hi,
> >
> > Rebased patch attached.
>
> Patch LGTM, it works as intended. My only concern is the unbounded max
> limit; which can cause problems. I think 'max_wal_size' is a
> reasonable limit. Perhaps we can add a 'force' boolean option to
> function, then it can bypass the 'max_wal_size' limit; what do you
> think?
>
Thanks for the review! I like the idea you suggested.
Let me try implementing it that way.
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-08-03 12:14:17 | Re: datachecksums: handle invalid and dropped databases during enable |
| Previous Message | Alvaro Herrera | 2026-08-03 11:54:03 | Re: question about is_valid parameter in set_attnotnull |