| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some more pg_dump refactoring |
| Date: | 2020-07-08 04:42:14 |
| Message-ID: | alpine.DEB.2.22.394.2007080640000.261743@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hallo Peter,
>>>> Would it make sense to accumulate in the other direction, older to newer,
>>>> so that new attributes are added at the end of the select?
>>> I think that could make sense, but the current style was introduced by
>>> daa9fe8a5264a3f192efa5ddee8fb011ad9da365. Should we revise that?
>> It seems to me more logical to do it while you're at it, but you are the
>> one writing the patches:-)
>
> What do you think about this patch to reorganize the existing code from that
> old commit?
I think it is a definite further improvement.
Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to
me.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2020-07-08 04:53:52 | Re: Proposal: Automatic partition creation |
| Previous Message | kato-sho@fujitsu.com | 2020-07-08 04:25:16 | RE: Performing partition pruning using row value |