| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some more pg_dump refactoring |
| Date: | 2020-07-07 07:00:38 |
| Message-ID: | e6556d43-ded2-9a7b-4536-9a3cf59c796b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-06-30 16:56, Fabien COELHO wrote:
>>> Would it make sense to accumulate in the other direction, older to newer,
>>> so that new attributes are added at the end of the select?
>> I think that could make sense, but the current style was introduced by
>> daa9fe8a5264a3f192efa5ddee8fb011ad9da365. Should we revise that?
> It seems to me more logical to do it while you're at it, but you are the
> one writing the patches:-)
What do you think about this patch to reorganize the existing code from
that old commit?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_dump-Further-reorganize-getTableAttrs.patch | text/plain | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2020-07-07 07:03:20 | Re: Yet another fast GiST build (typo) |
| Previous Message | Daniel Gustafsson | 2020-07-07 06:41:41 | Re: Cache lookup errors with functions manipulation object addresses |