| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some more pg_dump refactoring |
| Date: | 2020-07-09 14:14:47 |
| Message-ID: | 68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-07-08 06:42, Fabien COELHO wrote:
>> What do you think about this patch to reorganize the existing code from that
>> old commit?
>
> I think it is a definite further improvement.
>
> Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to
> me.
Thanks. I have committed that, and attached is my original patch
adjusted to this newer style.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-pg_dump-Reorganize-dumpFunc-and-dumpAgg.patch | text/plain | 22.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-09 14:44:10 | Re: Is this a bug in pg_current_logfile() on Windows? |
| Previous Message | Stephen Frost | 2020-07-09 14:03:30 | Re: Default setting for enable_hashagg_disk |