Re: pgbench - allow to create partitioned tables

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - allow to create partitioned tables
Date: 2019-09-13 08:05:13
Message-ID: alpine.DEB.2.21.1909130954110.20765@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Dilip,

> Generally, we give one blank line between the variable declaration and
> the first statement of the block.

Ok.

> (p-1) -> (p - 1)

Ok.

> I am just wondering will it be a good idea to expand it to support
> multi-level partitioning?

ISTM that how the user could specify multi-level parameters is pretty
unclear, so I would let that as a possible extension if someone wants it
enough.

Attached v6 implements the two cosmetic changes outlined above.

--
Fabien.

Attachment Content-Type Size
pgbench-init-partitioned-6.patch text/x-diff 12.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2019-09-13 08:06:46 Re: proposal - patch: psql - sort_by_size
Previous Message Pavel Stehule 2019-09-13 07:35:24 Re: proposal - patch: psql - sort_by_size