| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - allow to create partitioned tables |
| Date: | 2019-09-13 04:04:50 |
| Message-ID: | CAFiTN-uvoVjn2FVsw-1aHakWUVM6cE9sUix=_N0H7jZEOnc87A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 11, 2019 at 6:08 PM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> Attached an updated version.
I have reviewed the patch and done some basic testing. It works as
per the expectation
I have a few cosmetic comments
1.
+ if (partitions >= 1)
+ {
+ char ff[64];
+ ff[0] = '\0';
+ append_fillfactor(ff, sizeof(ff));
Generally, we give one blank line between the variable declaration and
the first statement of the block.
2.
+ if (p == 1)
+ sprintf(minvalue, "minvalue");
+ else
+ sprintf(minvalue, INT64_FORMAT, (p-1) * part_size + 1);
(p-1) -> (p - 1)
I am just wondering will it be a good idea to expand it to support
multi-level partitioning?
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-09-13 04:22:05 | Re: Berserk Autovacuum (let's save next Mandrill) |
| Previous Message | Michael Paquier | 2019-09-13 03:30:41 | Re: [HACKERS] [PATCH] pageinspect function to decode infomasks |