Re: [HACKERS] [WIP] Zipfian distribution in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alik Khilazhev <a(dot)khilazhev(at)postgrespro(dot)ru>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Date: 2017-11-20 07:45:32
Message-ID: alpine.DEB.2.20.1711200647580.11926@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Alik,

Patch applies with "patch", but not with "git apply", probably because it
is in CR-NL eol format. No big deal.

Documentation has been switched from SGML to XML, so now tags must be
explicitely closed, i.e. use <foo>x</foo> instead of <foo>x</>.

Patch compiles with a warning:

pgbench.c: In function ‘getZipfianRand’:
pgbench.c:905:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

Declaration must move before assertion.

The random_zipfian(1,100,2) call result is not tested.

"1 times" -> "once".

"array overflow on \random_zipfian" remove spurious "\".


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2017-11-20 07:49:48 Re: [HACKERS] Proposal: generic WAL compression
Previous Message Masahiko Sawada 2017-11-20 07:12:29 Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.