Re: [HACKERS] Proposal: generic WAL compression

From: Antonin Houska <ah(at)cybertec(dot)at>
To: Oleg Ivanov <o(dot)ivanov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Proposal: generic WAL compression
Date: 2017-11-20 07:49:48
Message-ID: 8015.1511164188@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Antonin Houska <ah(at)cybertec(dot)at> wrote:

> Oleg Ivanov <o(dot)ivanov(at)postgrespro(dot)ru> wrote:
> > In order to overcome that issue, I would like to propose the patch, which
> > provides possibility to use another approach of the WAL record
> > construction.
> After having spent several hours reviewing this patch I dare to send the
> following comments:

One more idea:

I think the metadata (ALIGN_GAP) should be stored separate from the actual
data so that you can use memcpy() instead of this loop:

while (i < j)
char c = targetRegionAligned[i++];

writeToPtr(ptr, c);

Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-11-20 08:38:22 Re: [HACKERS] Proposal: Local indexes for partitioned table
Previous Message Fabien COELHO 2017-11-20 07:45:32 Re: [HACKERS] [WIP] Zipfian distribution in pgbench