Re: pgbench: Skipping the creating primary keys after initialization

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench: Skipping the creating primary keys after initialization
Date: 2017-09-05 07:06:28
Message-ID: alpine.DEB.2.20.1709050856360.6547@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> Attached the latest patch. Please review it.

Patch applies and compiles cleanly.

Three very minor points:

Typo added in the documentation: ".Each" -> ". Each".

In "case 8:" there is a very long line which lacks a newline before
pg_realloc second argument.

I think that the check should silently accept spaces as they are ignored
by init later, i.e.:

sh> ./pgbench -i -I "ctg vpf"
invalid custom initialization script command " "
possible commands are: "c", "t", "g", "v", "p", "f"

Could just work...

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2017-09-05 07:08:22 Re: Copyright in partition.h and partition.c
Previous Message Beena Emerson 2017-09-05 07:01:03 Re: Default Partition for Range