| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench: Skipping the creating primary keys after initialization |
| Date: | 2017-09-05 07:24:04 |
| Message-ID: | CAD21AoAe-rBWqdtGySoJM0My+bc3iqU9Xqq-qEFj=jbqP29M7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 5, 2017 at 4:06 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
>> Attached the latest patch. Please review it.
>
>
> Patch applies and compiles cleanly.
>
> Three very minor points:
>
> Typo added in the documentation: ".Each" -> ". Each".
>
> In "case 8:" there is a very long line which lacks a newline before
> pg_realloc second argument.
Sorry, I don't follow that. You meant I should add a newline before
pg_realloc()? That is,
+ initialize_cmds =
+ (char *) pg_realloc(initialize_cmds,
+ sizeof(char) * n_cmds + 1);
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2017-09-05 07:40:21 | Re: postgres_fdw bug in 9.6 |
| Previous Message | Amit Langote | 2017-09-05 07:08:22 | Re: Copyright in partition.h and partition.c |