Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date: 2016-10-24 20:49:20
Message-ID: alpine.DEB.2.20.1610242228440.20001@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


>>> I find it annoying that "//" comments are not supported, or having to
>>> declare variables at the beginning of a block instead of when first used...
>
>> I think some c99 features would be nice (variadic macros for one), but
>> those particular two get a big "meh" from me.
>
> Yeah. Personally, I'd want to continue the rule against // comments just
> as a matter of maintaining stylistic consistency. Code that's got a
> random mishmash of // and /* comments looks messy, if you ask me.

Coding styles are by definition a subjective area... Homogeneity
*whatever the precise but reasonable rules* in a code base is a good
thing.

> An alternative that would be worth considering is to adopt a uniform
> rule of // for line-ending comments and /* for all other uses.

Why not. As far as comments are concerned, editors usually highlight them
in some color, and my eyes get used to the comment color, so the simpler &
shorter the better, really.

> We'd have to teach pgindent about that, and I dunno how hard that is.

Maybe it is enough to just to turn "/* no-nl */" to "// no-nl" in
pgindent's post_indent, but probably I'm too naïve:-)

--
Fabien.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Petr Jelinek 2016-10-24 20:53:27 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Previous Message Tom Lane 2016-10-24 20:20:26 pgsql: Stamp 9.1.24.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan Katz 2016-10-24 20:50:53 Re: Press Release Draft - 2016-10-27 Cumulative Update
Previous Message Alvaro Herrera 2016-10-24 20:40:14 Re: Patch: Implement failover on libpq connect level.