| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| Date: | 2016-10-24 19:03:19 |
| Message-ID: | 17167.1477335799@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Fabien COELHO wrote:
>> I find it annoying that "//" comments are not supported, or having to
>> declare variables at the beginning of a block instead of when first used...
> I think some c99 features would be nice (variadic macros for one), but
> those particular two get a big "meh" from me.
Yeah. Personally, I'd want to continue the rule against // comments just
as a matter of maintaining stylistic consistency. Code that's got a
random mishmash of // and /* comments looks messy, if you ask me.
An alternative that would be worth considering is to adopt a uniform
rule of // for line-ending comments and /* for all other uses. We'd
have to teach pgindent about that, and I dunno how hard that is.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2016-10-24 19:11:45 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| Previous Message | Alvaro Herrera | 2016-10-24 18:31:03 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2016-10-24 19:11:45 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| Previous Message | Tom Lane | 2016-10-24 18:59:48 | Re: Press Release Draft - 2016-10-27 Cumulative Update |