Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

On 24/10/16 21:11, Stephen Frost wrote:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>>> Fabien COELHO wrote:
>>>> I find it annoying that "//" comments are not supported, or having to
>>>> declare variables at the beginning of a block instead of when first used...
>>
>>> I think some c99 features would be nice (variadic macros for one), but
>>> those particular two get a big "meh" from me.
>>
>> Yeah. Personally, I'd want to continue the rule against // comments just
>> as a matter of maintaining stylistic consistency. Code that's got a
>> random mishmash of // and /* comments looks messy, if you ask me.
>
> +1
>

+1

>> An alternative that would be worth considering is to adopt a uniform
>> rule of // for line-ending comments and /* for all other uses. We'd
>> have to teach pgindent about that, and I dunno how hard that is.
>
> I'm not sure it's worth the resulting mess.
>

I think the current commenting style stylistically nicer.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services