| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, tristan(at)partin(dot)io, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Warn when io_min_workers exceeds io_max_workers |
| Date: | 2026-07-06 02:41:06 |
| Message-ID: | aksVwu5XU34spFbD@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 23, 2026 at 11:02:57AM -0500, Baji Shaik wrote:
> Thanks for the review.
This patch was still very noisy. If running a bunch of reloads, we'd
still emit a WARNING all the time even if none of the bounds change.
This can be easily avoided: save the previous bound value before
ProcessConfigFile(), then recheck and proceed if one of the values has
changed.
Tweaked that and a few more things, then applied the result.
> I have kept the autovacuum message change as 0002 since Michael
> suggested unifying the format strings. If the consensus is to
> leave the existing autovacuum message alone, I'm happy to drop it.
This is useful on HEAD, so done that as 7905416eef9b.
Thanks,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-07-06 02:43:20 | RE: Re-read subscription state after lock in AlterSubscription |
| Previous Message | Michael Paquier | 2026-07-06 01:54:47 | Re: add validations for required callbacks during pgstat_register_kind() |