Re: [PATCH] Warn when io_min_workers exceeds io_max_workers

From: Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: michael(at)paquier(dot)xyz, tristan(at)partin(dot)io, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Warn when io_min_workers exceeds io_max_workers
Date: 2026-06-23 16:02:57
Message-ID: CA+fm-RMCKvKu8FR7m9D6Vusf_OnSVBe1T1Q2BVRS6b_X-nxvfQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 23, 2026 at 12:36 AM Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
wrote:

> Also, "Re-check" in the second call-site comment feels a bit vague to
> me, since the previous call is quite far away. Perhaps both call-site
> comments could simply describe checking the relevant GUC values, one
> at startup and the other after a configuration reload. Regards,
>

Thanks for the review.

Attached v3 with both comments updated to
/* Emit a WARNING if io_min_workers > io_max_workers. */
as suggested.

I have kept the autovacuum message change as 0002 since Michael
suggested unifying the format strings. If the consensus is to
leave the existing autovacuum message alone, I'm happy to drop it.

Thanks,
Baji Shaik.

Attachment Content-Type Size
v3-0001-Warn-when-io_min_workers-exceeds-io_max_workers.patch application/octet-stream 2.4 KB
v3-0002-Use-parameterized-GUC-names-in-check_av_worker_gu.patch application/octet-stream 1.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Salma El-Sayed 2026-06-23 16:03:53 Re: [GSoC 2026] - B-tree Index Bloat Reduction - Approach & Questions
Previous Message Kirk Wolak 2026-06-23 15:57:20 Re: [GSoC 2026] - B-tree Index Bloat Reduction - Approach & Questions