RE: Re-read subscription state after lock in AlterSubscription

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Bertrand Drouvot' <bertranddrouvot(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Re-read subscription state after lock in AlterSubscription
Date: 2026-07-06 02:43:20
Message-ID: OS9PR01MB121496CC9813CBE8C2AB20764F5F12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Bertrand,

Thanks for updating the patch. I found one issue:

```
/* DROP hook for the subscription being removed */
InvokeObjectDropHook(SubscriptionRelationId, subid, 0);

```

I think the reporting should be after the loop, otherwise the wrong subid can be
reported. Am I missing something?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-07-06 03:11:53 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Michael Paquier 2026-07-06 02:41:06 Re: [PATCH] Warn when io_min_workers exceeds io_max_workers