| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use \if/\endif to remove non-libxml2 expected output in regression tests |
| Date: | 2026-06-15 00:49:21 |
| Message-ID: | ai9MEe9_vRVTAbR5@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jun 14, 2026 at 07:33:54PM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Positioning the \if after the three initial INSERT queries (\if query
>> that counts the number of tuples inserted), like in the patch I have
>> posted upthread, is able to hit NO_XML_SUPPORT() in xmlin(). That
>> would be enough. Would you agree with that?
>
> Works for me.
Okay. So fusioning my stuff, your stuff and Daniel's comment
suggestion, I get the attached. That's working here with my system's
libxml2 (2.12.10), libxml2 2.9.3 and without libxml2.
Does that look right?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Trim-regression-test-expected-output-for-xml.patch | text/plain | 166.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-06-15 00:56:29 | Re: Use \if/\endif to remove non-libxml2 expected output in regression tests |
| Previous Message | Michael Paquier | 2026-06-15 00:14:31 | Re: injection_points: Switch wait/wakeup to use atomics rather than latches |