| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use \if/\endif to remove non-libxml2 expected output in regression tests |
| Date: | 2026-06-15 00:56:29 |
| Message-ID: | 132988.1781484989@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Okay. So fusioning my stuff, your stuff and Daniel's comment
> suggestion, I get the attached. That's working here with my system's
> libxml2 (2.12.10), libxml2 2.9.3 and without libxml2.
> Does that look right?
Locally, I'd changed the line
+INSERT INTO xmltest VALUES (3, '<value>two</wrong> ');
to be
+INSERT INTO xmltest VALUES (3, '<value>three</wrong> ');
after sending my 1.0 patch; it was basically a copy-and-paste
error that it wasn't "three" already. That would have follow-on
effects in xml.out and xml_1.out, so if you don't feel like
adopting it, I won't complain hard. No other suggestions.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-06-15 01:11:03 | Re: Fix ALTER DOMAIN VALIDATE CONSTRAINT locking |
| Previous Message | Michael Paquier | 2026-06-15 00:49:21 | Re: Use \if/\endif to remove non-libxml2 expected output in regression tests |