Re: Use \if/\endif to remove non-libxml2 expected output in regression tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
Date: 2026-06-14 23:33:54
Message-ID: 128417.1781480034@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Sun, Jun 14, 2026 at 07:12:24PM -0400, Tom Lane wrote:
>> I think it's worth covering, say, one of those paths, but we don't
>> have to hit every one of the duplicate copies. So what do you think
>> of putting the early-exit \if after the first test that produces
>> one of those failures?

> Positioning the \if after the three initial INSERT queries (\if query
> that counts the number of tuples inserted), like in the patch I have
> posted upthread, is able to hit NO_XML_SUPPORT() in xmlin(). That
> would be enough. Would you agree with that?

Works for me.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-06-15 00:14:31 Re: injection_points: Switch wait/wakeup to use atomics rather than latches
Previous Message Michael Paquier 2026-06-14 23:26:38 Re: Use \if/\endif to remove non-libxml2 expected output in regression tests