| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes |
| Date: | 2026-05-11 16:21:17 |
| Message-ID: | agIBukr85PlM6um_@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-May-11, Chao Li wrote:
> > On May 10, 2026, at 06:38, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > I think it would be a good idea to make identity_key_equal() not deform
> > all attributes, but instead only up to the last one it needs for the key
> > comparisons.
>
> That’s true. Please see v3.
Thanks. I did one further small change, namely to determine these last
attnums just once per run rather than once per tuple. Pushed now.
Thanks for testing!
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-05-11 16:42:40 | Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments |
| Previous Message | Nisha Moond | 2026-05-11 15:55:12 | Re: pg_createsubscriber: Fix incorrect handling of cleanup flags |