Re: pg_createsubscriber: Fix incorrect handling of cleanup flags

From: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber: Fix incorrect handling of cleanup flags
Date: 2026-05-11 15:55:12
Message-ID: CABdArM5FmQNRXCZws=eY-hQTPYM7=t3Z5e10HnkFt9UNWt=EFA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 11, 2026 at 6:53 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Sun, May 10, 2026 at 1:30 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > On Wed, Apr 1, 2026 at 1:44 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > >
> > > The patch needed rebasing after recent changes in pg_createsubscriber
> > > under commit d6628a5.
> > > Please find the rebased patch (v3) attached.
> > >
> >
> > Needed a rebase after recent commits. Attached the rebased v4 patch.
>
> Thanks for updating the patch! It looks good to me.
>
> We can remove the third argument, made_publication, from drop_publication()
> since it is no longer used?
>

+1, attached the updated patch.

--
Thanks,
Nisha

Attachment Content-Type Size
v5-0001-Fix-incorrect-cleanup-flag-handling-in-pg_creates.patch application/octet-stream 4.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-05-11 16:21:17 Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes
Previous Message Álvaro Herrera 2026-05-11 15:50:41 Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments