Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, Payal Singh <payals1(at)umbc(dot)edu>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: 2026-05-11 16:42:40
Message-ID: 2152953.1778517760@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> Just passing by, but I think this comment should be handled manually as
> well, as I doubt we want it to end up this way:

Hmmm ... yeah, probably. In isolation the diff had looked all right
to me, but it would probably make more sense to keep this comment
aligned with the surrounding code. I'm thinking like

}
/*-----
* limit (sum(1/i^2),i=1,inf) = pi^2/6
* resj = sum(wi/i^2),i=1,noccurrence,
* wi - should be sorted desc,
* don't sort for now, just choose maximum weight.
* This should be corrected
* Oleg Bartunov
*/
res = res + (wjm + resj - wjm / ((jm + 1) * (jm + 1))) / 1.64493406685;

> (Not that I understand what this is trying to tell me, mind)

Me either :-(

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Bauman 2026-05-11 18:18:52 Re: Doc update proposal for the note on log_statement in the runtime config for logging page
Previous Message Álvaro Herrera 2026-05-11 16:21:17 Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes