| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: off-by-one in pg_repack index loop |
| Date: | 2026-05-04 18:02:01 |
| Message-ID: | afjfEPsb8yFyssw8@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Apr-29, John Naylor wrote:
> On Tue, Apr 14, 2026 at 2:35 PM Lakshmi N <lakshmin(dot)jhs(at)gmail(dot)com> wrote:
> > if (unlikely(list_length(ind_oids_new) < pos))
> > elog(ERROR, "list of new indexes too short");
> > ident_idx_new = list_nth_oid(ind_oids_new, pos);
> > break;
>
> If we're going to change this, let's also get rid of the "unlikely",
> since it's just a noise word here -- see commit 913ec71d6.
Thanks, pushed that way.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Computing is too important to be left to men." (Karen Spärck Jones)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | SATYANARAYANA NARLAPURAM | 2026-05-04 18:08:06 | Re: [Bug]Vacuum full silently NULL out fast default columns |
| Previous Message | Álvaro Herrera | 2026-05-04 17:41:38 | Re: [Bug]Vacuum full silently NULL out fast default columns |