| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Antonin Houska <ah(at)cybertec(dot)at> |
| Subject: | Re: [Bug]Vacuum full silently NULL out fast default columns |
| Date: | 2026-05-04 17:41:38 |
| Message-ID: | afjYnSJeXoa2LFaU@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-May-04, SATYANARAYANA NARLAPURAM wrote:
> On Mon, May 4, 2026 at 6:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > A quick bisect run agrees that it broke here:
> >
> > 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit
> > commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD)
> > Author: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
> > Date: Mon Apr 6 21:55:08 2026 +0200
> >
> > Add CONCURRENTLY option to REPACK
Right.
> Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC in
> V1. Before the change loop was not breaking early, I fixed that as
> well in V2.
Yeah, this seems a good approach to me. I propose some more comment
updates though, and I also thought it'd be a good idea to add a test for
REPACK CONCURRENTLY while at it.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Don-t-lose-column-values-on-REPACK.patch | text/x-diff | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-05-04 18:02:01 | Re: off-by-one in pg_repack index loop |
| Previous Message | Tomas Vondra | 2026-05-04 17:16:37 | Re: EXPLAIN: showing ReadStream / prefetch stats |