Re: [Bug]Vacuum full silently NULL out fast default columns

Hi,

On Mon, May 4, 2026 at 10:41 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:

> On 2026-May-04, SATYANARAYANA NARLAPURAM wrote:
>
> > On Mon, May 4, 2026 at 6:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > > A quick bisect run agrees that it broke here:
> > >
> > > 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit
> > > commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD)
> > > Author: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
> > > Date: Mon Apr 6 21:55:08 2026 +0200
> > >
> > > Add CONCURRENTLY option to REPACK
>
> Right.
>
> > Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC in
> > V1. Before the change loop was not breaking early, I fixed that as
> > well in V2.
>
> Yeah, this seems a good approach to me. I propose some more comment
> updates though, and I also thought it'd be a good idea to add a test for
> REPACK CONCURRENTLY while at it.
>

This patch LGTM. It applied cleanly and all the tests passed.

Thanks,
Satya