| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo |
| Date: | 2020-07-08 12:27:04 |
| Message-ID: | ddde0b18-bf6c-5744-b61b-709fd1e23d35@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/07/08 15:22, Fujii Masao wrote:
>
>
> On 2020/07/08 11:55, torikoshia wrote:
>> On 2020-07-08 11:15, Fujii Masao wrote:
>>> On 2020/07/08 11:02, torikoshia wrote:
>>>> Hi,
>>>>
>>>> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
>>>> but it seems that should be "XLogSegNo" because this variable is
>>>> segment number.
>>>>
>>>> How do you think?
>>>
>>> I agree that using XLogRecPtr for slot_keep_segs is incorrect.
>>> But this variable indicates the number of segments rather than
>>> segment no, uint64 seems better. Thought?
>>
>> That makes sense.
>> The number of segments and segment number are different.
>
> Yes, so patch attached. I will commit it later.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-07-08 12:34:54 | Re: Global snapshots |
| Previous Message | Rémi Lapeyre | 2020-07-08 11:45:01 | [PATCH v2] Allow COPY "text" to output a header and add header matching mode to COPY FROM |