Re: Latest Data::Dumper breaks hstore_plperl regression test

From: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Latest Data::Dumper breaks hstore_plperl regression test
Date: 2017-05-14 03:43:51
Message-ID: CAMsr+YHFFZnjDQ746QTzwy4me8S8fGM_99BSTmR=4zQHPF0TTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14 May 2017 11:33, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:

On Sat, May 13, 2017 at 6:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Or at least, that's what I surmise from the fact that buildfarm critter
> caiman has been failing that test for the last day or so, with symptoms
> indicating whitespace changes in Data::Dumper output. Some poking into
> the Fedora repo shows that rawhide updated perl-Data-Dumper from 2.161
> to 2.167 on May 11, so that fits ...

Depending on the precise details of how Data::Dumper prints things
doesn't seem like a particularly good idea.

Surely Test::More::is_deeply is the way to go here.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-05-14 03:44:22 Re: Hash Functions
Previous Message Robert Haas 2017-05-14 03:32:29 Re: Latest Data::Dumper breaks hstore_plperl regression test