Re: [PATCH] remove incorrect comment in pg_resetwal.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Gavin LYU <gavin790417(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] remove incorrect comment in pg_resetwal.c
Date: 2026-01-16 06:53:42
Message-ID: aWngdjv3OfcX5-4p@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 16, 2026 at 02:45:42PM +0800, Gavin LYU wrote:
> In the block handling the -e option, there’s a comment that appears to be a
> copy-paste error (line 190 and 191). It references a second %s, but none
> exists in that format string. Moreover, similar argument-handling code for
> other options doesn’t include such a comment.
>
> I believe it should be removed.

I disagree. This note still looks helpful to me when it comes to
translation even if it is incorrect: the %s markup refers to an option
switch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-01-16 06:54:40 Re: fix a spelling mistake
Previous Message shveta malik 2026-01-16 06:52:50 Re: Simplify code building the LR conflict messages