| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | yangyz <1197620467(at)qq(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fix a spelling mistake |
| Date: | 2026-01-16 06:54:40 |
| Message-ID: | 0D4362F7-505F-440D-B2EC-8ADAFEEE645A@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 16, 2026, at 11:19, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jan 16, 2026 at 08:58:06AM +0800, yangyz wrote:
>> When I was reading the comment of the function
>> bt_report_duplicate(), I discovered a spelling mistake. Therefore, I
>> sent a patch to fix this issue.
>
> Thanks for the report. I have grabbed this fix and will apply all
> these things once the stack gets bigger.
> --
> Michael
Hi Michael,
I can add a couple to your stack:
1 - This one I ever reported, but was missed in 94a24b4ee5a
```
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 596105ee078..a9529692ae3 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -2398,7 +2398,7 @@ pg_available_extension_versions(PG_FUNCTION_ARGS)
/*
* Ignore already-found names. They are not reachable by the
- * path search, so don't shown them.
+ * path search, so don't show them.
*/
extname_str = makeString(extname);
if (list_member(found_ext, extname_str))
```
2 - I happened to notice this one yesterday while reviewing your patch, but I hesitated to file a trivial patch, so I didn’t.
```
diff --git a/src/backend/statistics/extended_stats_funcs.c b/src/backend/statistics/extended_stats_funcs.c
index b4b1bf26463..c0af146451e 100644
--- a/src/backend/statistics/extended_stats_funcs.c
+++ b/src/backend/statistics/extended_stats_funcs.c
@@ -120,7 +120,7 @@ delete_pg_statistic_ext_data(Oid stxoid, bool inherited)
HeapTuple oldtup;
bool result = false;
- /* Is there already a pg_statistic tuple for this attribute? */
+ /* Is there already a pg_statistic_ext_data tuple for this attribute? */
oldtup = SearchSysCache2(STATEXTDATASTXOID,
ObjectIdGetDatum(stxoid),
BoolGetDatum(inherited));
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-01-16 07:10:50 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | Michael Paquier | 2026-01-16 06:53:42 | Re: [PATCH] remove incorrect comment in pg_resetwal.c |