| From: | Gavin LYU <gavin790417(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | [PATCH] remove incorrect comment in pg_resetwal.c |
| Date: | 2026-01-16 06:45:42 |
| Message-ID: | CANGnNoXevdxt8yL9s0-1SzUXAd-OiaEQbCeUp8aNhrKbCYeGgA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Hackers,
While reading the code, I noticed an incorrect comment in the main() function
of src/bin/pg_resetwal/pg_resetwal.c.
In the block handling the -e option, there’s a comment that appears to be a
copy-paste error (line 190 and 191). It references a second %s, but none
exists in that format string. Moreover, similar argument-handling code for
other options doesn’t include such a comment.
I believe it should be removed.
Attached is a patch that fixes this issue.
Best regards,
--
Gavin LYU
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-PATCH-remove-wrong-comment-in-pg_resetwal.c.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2026-01-16 06:47:11 | Re: Can we change pg_rewind used without wal_log_hints and data_checksums |
| Previous Message | Soumya S Murali | 2026-01-16 06:35:44 | Re: 001_password.pl fails with --without-readline |