| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2025-10-27 23:35:15 |
| Message-ID: | aQABs_2dbXmGXDvv@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote:
> /*
> * DISABLE_LEADER_PARTICIPATION disables the leader's participation in
> * parallel index builds. This may be useful as a debugging aid.
> -#undef DISABLE_LEADER_PARTICIPATION
> + *#undef DISABLE_LEADER_PARTICIPATION
> */
>
> IMHO we should either remove this line or move it out of the comment.
> AFAICT we ordinarily don't #undef debugging stuff like this, presumably so
> you can change it with compile flags.
I would put this one on a separate line, outside the comment. It's
minor, still we use this style in pg_config_manual.h. See around
REALLOCATE_BITMAPSETS.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-10-27 23:55:43 | Re: display hot standby state in psql prompt |
| Previous Message | Michael Paquier | 2025-10-27 23:30:51 | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |