| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2025-10-28 00:36:33 |
| Message-ID: | 7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 28, 2025, at 07:35, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote:
>> /*
>> * DISABLE_LEADER_PARTICIPATION disables the leader's participation in
>> * parallel index builds. This may be useful as a debugging aid.
>> -#undef DISABLE_LEADER_PARTICIPATION
>> + *#undef DISABLE_LEADER_PARTICIPATION
>> */
>>
>> IMHO we should either remove this line or move it out of the comment.
>> AFAICT we ordinarily don't #undef debugging stuff like this, presumably so
>> you can change it with compile flags.
>
> I would put this one on a separate line, outside the comment. It's
> minor, still we use this style in pg_config_manual.h. See around
> REALLOCATE_BITMAPSETS.
> --
> Michael
+1
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | iosif | 2025-10-28 00:55:48 | when called from extract_restriction_or_clauses(), the 4th check in join_clause_is_movable_to() is unnecessary |
| Previous Message | Fujii Masao | 2025-10-27 23:55:43 | Re: display hot standby state in psql prompt |