Re: Consistently use the XLogRecPtrIsInvalid() macro

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: 2025-11-07 15:03:03
Message-ID: aQ4KJws+Bx4C20nK@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, Nov 07, 2025 at 02:37:32PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-07, Bertrand Drouvot wrote:
>
> > Agree, will modify the .cocci scripts that way.
>
> I just noticed that we missed this ... maybe you want to include it also?
>
> - MyProc->waitLSN = 0;
> + MyProc->waitLSN = InvalidXLogRecPtr;
>
> - lastLSN = 0;
> + lastLSN = InvalidXLogRecPtr;
>
> - MyProc->waitLSN = 0;
> + MyProc->waitLSN = InvalidXLogRecPtr;

Yeah, that's another story here that is worth to look at too. Will do.

I'm currently working on the RegProcedureIsValid() and OidIsValid() cases,
will share once done.

>
> > Now that XLogRecPtrIsValid() is available in back branches, I agree that we
> > can be less conservative and not wait until v24. v21 looks like good timing to
> > me.
>
> Cool, please resubmit.

Sure, done in the attached.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v7-0001-Introduce-pg_attribute_deprecated-and-deprecate-X.patch text/x-diff 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-11-07 15:10:19 Re: LTO aggressively optimizing out function despite explicit calls in logical decoding
Previous Message Ranier Vilela 2025-11-07 15:03:01 Re: Xlogprefetcher: Use atomic add for increment counter