| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Consistently use the XLogRecPtrIsInvalid() macro |
| Date: | 2025-11-07 16:05:11 |
| Message-ID: | 2d6e23db-f2f8-44ce-ad7a-258612dd6409@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.11.25 16:03, Bertrand Drouvot wrote:
> +/*
> + * Mark a declaration as deprecated with a custom message. The compiler will
> + * emit a warning when the deprecated entity is used.
> + */
> +#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L || \
> +defined(__cplusplus) && __cplusplus >= 201402L
This could use some parentheses to disambiguate the && and ||.
Also the second line could be indented (or just put it on one line).
> +#define pg_attribute_deprecated(msg) [[deprecated(msg)]]
> +#elif defined(__GNUC__) || defined(__clang__)
The __clang__ part is not needed, because clang defines __GNUC__ also.
> +#define pg_attribute_deprecated(msg) __attribute__((deprecated(msg)))
> +#elif defined(_MSC_VER)
> +#define pg_attribute_deprecated(msg) __declspec(deprecated(msg))
> +#else
> +#define pg_attribute_deprecated(msg)
> +#endif
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2025-11-07 16:05:55 | Re: Sequence Access Methods, round two |
| Previous Message | Tom Lane | 2025-11-07 16:04:11 | Re: Some efforts to get rid of "long" in our codebase |