| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Lauri Siltanen <lauri(dot)siltanen(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Feature: psql - display current search_path in prompt |
| Date: | 2025-10-24 14:20:38 |
| Message-ID: | aPuLNucQ-559GSUM@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 24, 2025 at 05:10:13PM +0300, Florents Tselai wrote:
> Good catch. v2 attached
Thanks.
+ <varlistentry id="app-psql-prompting-S">
+ <term><literal>%S</literal></term>
+ <listitem><para>The current search path.</para></listitem>
+ </varlistentry>
I'd suggest linking to a page about the search_path [0].
+extern const char *session_search_path(void);
This function appears to be unused.
+ /*
+ * Distinguish unknown (NULL) from an empty but valid search_path ("").
+ * If not connected or older server doesn't report it via ParameterStatus,
+ * show "?".
+ */
+ if (!pset.db || PQparameterStatus(pset.db, "search_path") == NULL)
+ strlcpy(buf, "?", sizeof(buf));
+ else
+ strlcpy(buf, PQparameterStatus(pset.db, "search_path"), sizeof(buf));
+ break;
Shouldn't we move most of this logic to session_search_path() and use it
here?
[0] https://www.postgresql.org/docs/current/ddl-schemas.html#DDL-SCHEMAS-PATH
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-10-24 14:23:41 | Re: Improving and extending int128.h to more of numeric.c |
| Previous Message | Andres Freund | 2025-10-24 14:20:17 | Re: Instability of phycodorus in pg_upgrade tests with JIT |