Re: Feature: psql - display current search_path in prompt

On Fri, Oct 24, 2025 at 5:20 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

> On Fri, Oct 24, 2025 at 05:10:13PM +0300, Florents Tselai wrote:
> > Good catch. v2 attached
>
> Thanks.
>
> + <varlistentry id="app-psql-prompting-S">
> + <term><literal>%S</literal></term>
> + <listitem><para>The current search path.</para></listitem>
> + </varlistentry>
>
> I'd suggest linking to a page about the search_path [0].
>

Done

>
> +extern const char *session_search_path(void);
>
> This function appears to be unused.
>
> + /*
> + * Distinguish unknown (NULL) from
> an empty but valid search_path ("").
> + * If not connected or older
> server doesn't report it via ParameterStatus,
> + * show "?".
> + */
> + if (!pset.db ||
> PQparameterStatus(pset.db, "search_path") == NULL)
> + strlcpy(buf, "?",
> sizeof(buf));
> + else
> + strlcpy(buf,
> PQparameterStatus(pset.db, "search_path"), sizeof(buf));
> + break;
>
> Shouldn't we move most of this logic to session_search_path() and use it
> here?
>

Yes