| From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Lauri Siltanen <lauri(dot)siltanen(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Feature: psql - display current search_path in prompt |
| Date: | 2025-10-24 14:10:13 |
| Message-ID: | CA+v5N41OrJYds8g-JaojkjWTpz35w4odMDYNriRdMHN17vR0MQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2025 at 11:52 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
> On Thu, Jun 12, 2025 at 06:57:37PM +0300, Florents Tselai wrote:
> > Absent any other feedback I'm marking this as Ready for Committer;
> > Said committer can push back on my arbitrary %S selection
> > https://commitfest.postgresql.org/patch/5808/
>
> PQparameterStatus() will return NULL if the parameter is not known. So,
> with this patch, using %S in a prompt when connected to a <v18 version of
> PostgreSQL will produce an empty string. Given an empty string is a valid
> value for search_path, I think we probably want to use a special value in
> this case. Perhaps we could use "?", which is much less likely to be a
> value for search_path.
>
Good catch. v2 attached
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-psql-Add-S-prompt-escape-to-display-current-searc.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Davydov | 2025-10-24 14:12:16 | Unused variable in perl test |
| Previous Message | Bryan Green | 2025-10-24 13:55:08 | Re: Avoid handle leak (src/bin/pg_ctl/pg_ctl.c) |