Re: Remove specific \r\n code in TAP for Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove specific \r\n code in TAP for Windows
Date: 2025-10-27 23:27:35
Message-ID: aP__5-hsUWksPjUP@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 27, 2025 at 08:33:57AM -0700, Jacob Champion wrote:
> Ah, sorry, I put part of my first attempt at it over in [1]. But I
> realize that's not very visible, nor does it address
> 003_ldap_connection_param_lookup.

Ahh, so you did post something. I have missed that

> I'm carrying a local diff that switches 003_ldap_ over to qq{} style.
> Attached in case you like it, but your patch LGTM too.

Your suggestions for the LDAP test are cleaner than what I came up
with, so reused these.

>> That would be up to the buildfarm to act as final judge, but any
>> objections in attempting to get rid of these like in the attached?
>> I would try first HEAD to be sure, then follow with an optional
>> backpatch.
>
> Sounds like a plan.

Time for a verdict, so applied on HEAD now.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-27 23:30:51 Re: [BUG] temporary file usage report with extended protocol and unnamed portals
Previous Message David Rowley 2025-10-27 23:16:28 Re: another autovacuum scheduling thread