| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove specific \r\n code in TAP for Windows |
| Date: | 2025-10-27 15:33:57 |
| Message-ID: | CAOYmi+kL0NADVLG5WMtomuhyc3AptMqEPQMad0fqQptJo8CyVA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2025 at 11:51 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> $subject has been mentioned by Jacob (in CC.) on Discord, and it does
> not seem like somebody took the time to propose a patch.
Ah, sorry, I put part of my first attempt at it over in [1]. But I
realize that's not very visible, nor does it address
003_ldap_connection_param_lookup.
I'm carrying a local diff that switches 003_ldap_ over to qq{} style.
Attached in case you like it, but your patch LGTM too.
> That would be up to the buildfarm to act as final judge, but any
> objections in attempting to get rid of these like in the attached?
> I would try first HEAD to be sure, then follow with an optional
> backpatch.
Sounds like a plan.
Thanks!
--Jacob
[1] https://postgr.es/m/CAOYmi%2BkYKPXCfiAF3xAu%2BcHYSLYEc4OC9Wsh2nebwWboNbkpeQ%40mail.gmail.com
| Attachment | Content-Type | Size |
|---|---|---|
| 003_ldap_newlines.diff.txt | text/plain | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Geier | 2025-10-27 15:50:33 | Re: Use merge-based matching for MCVs in eqjoinsel |
| Previous Message | Sergey Prokhorenko | 2025-10-27 15:33:31 | Отв.: Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions |