From: | Renzo Dani <arons7(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Extend documentation for pg_stat_replication.backend_xmin |
Date: | 2025-10-16 06:07:42 |
Message-ID: | CA+XOKQCjH2ZcnRdVDtg-KoASmDxz2ZqU2XSuU9Grups-ngw-Qg@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Really nice,
Thanks a lot for the info and review.
Taken into the patch.
Regards,
Renzo Dani
On Thu, Oct 16, 2025 at 5:32 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Oct 16, 2025 at 12:47 AM Renzo Dani <arons7(at)gmail(dot)com> wrote:
> >
> > Hi,
> > recently I had some issue understanding what was going on with a replica
> and the reported xmin.
> > I have than created a patch to better specify the value expected into
> the pg_stat_replication.backend_xmin field.
>
> +1
>
> + This field will be null if a replication slot is used; in that
> case, the xmin is available through <link
> linkend="view-pg-replication-slots">pg_replication_slots</link>.
>
> I think it would be better to also mention that this field is null
> when hot_standby_feedback is disabled.
>
> Also, <literal> tags should be used for "xmin", and a newline should
> be added to avoid an overly long line.
>
> Based on the above comments, how about revising it as follows?
>
> + This field will be null if a replication slot is used (in this
> case,
> + the standby's <literal>xmin</literal> is shown in
> + <link
> linkend="view-pg-replication-slots">pg_replication_slots</link>)
> + or if <varname>hot_standby_feedback</varname> is disabled.
>
> Regards,
>
> --
> Fujii Masao
>
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Extend-documentation-for-pg_stat_replication.back.patch | text/x-patch | 946 bytes |
v2-0002-Extend-documentation-for-pg_stat_replication.back.patch | text/x-patch | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2025-10-16 06:09:24 | Re: Preserve index stats during ALTER TABLE ... TYPE ... |
Previous Message | Michael Paquier | 2025-10-16 06:03:10 | Re: remove partColsUpdated |