Re: [PATCH] Add tests for Bitmapset

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: 2025-09-17 00:35:30
Message-ID: aMoCUogZMamHRJad@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 16, 2025 at 03:00:40PM -0700, Masahiko Sawada wrote:
> Thank you for updating the patch. It seems cfbot caught a regression
> test error[1] in a 32-bit build.

- bitmap_hash [1,3,5] | 49870778
+ bitmap_hash [1,3,5] | 1509752520

This one is able the hash value computation being not portable across
architectures. I would just change these to be non-NULL, I guess.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Kim 2025-09-17 01:10:56 Re: Proposal for enabling auto-vectorization for checksum calculations
Previous Message David Rowley 2025-09-17 00:26:11 Re: Fix missing EvalPlanQual recheck for TID scans