| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Greg Burd <greg(at)burd(dot)me> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-16 22:00:40 |
| Message-ID: | CAD21AoD4DOkiF1ZPZJn1bnZBx7WuTYqGx1j8nMk9FyCMrwm83w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 16, 2025 at 12:04 PM Greg Burd <greg(at)burd(dot)me> wrote:
>
> I've re-written the set of tests as suggested (I hope!). I've not
> re-run the coverage report (yet) to ensure we're at least as well
> covered as v3, but attached is v4 for your inspection (amusement?).
> I've tried to author the SQL tests such that failures clearly indicate
> what's at gone wrong.
>
> This exercise turned into a lot more LOC than I'd expected, I hope it
> provides some value to the community for testing this important data
> structure and helps to codify the API clearly.
Thank you for updating the patch. It seems cfbot caught a regression
test error[1] in a 32-bit build.
Regards,
[1] https://cirrus-ci.com/task/5290864655728640
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Koval | 2025-09-16 22:08:17 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Previous Message | Masahiko Sawada | 2025-09-16 21:56:15 | Re: encode/decode support for base64url |